Skip to content

Use local copy on action invocation#236

Merged
shahmishal merged 5 commits intoswiftlang:mainfrom
madrob:main
Feb 19, 2026
Merged

Use local copy on action invocation#236
shahmishal merged 5 commits intoswiftlang:mainfrom
madrob:main

Conversation

@madrob
Copy link
Contributor

@madrob madrob commented Feb 16, 2026

Fixes #220

@madrob madrob requested a review from a team as a code owner February 16, 2026 19:31
@madrob madrob marked this pull request as draft February 16, 2026 21:14
@madrob
Copy link
Contributor Author

madrob commented Feb 16, 2026

Looks like GITHUB_ACTION_PATH doesn't work the way that I thought it did. Investigating further.

@madrob
Copy link
Contributor Author

madrob commented Feb 16, 2026

Note to self, we might need to package those scripts inside of separate actions.

Publishing as an action bundles the directory contents with the action, so we can use helper scripts directly
@madrob madrob marked this pull request as ready for review February 16, 2026 23:05
@madrob
Copy link
Contributor Author

madrob commented Feb 18, 2026

I think the failure is unrelated

@FranzBusch
Copy link
Member

Are you sure the broken symlink and python lint failures are unrelated?

@madrob
Copy link
Contributor Author

madrob commented Feb 18, 2026

The windows failure is the one I was referring to. Everything else seems passed?

@FranzBusch
Copy link
Member

The windows failure is the one I was referring to. Everything else seems passed?

I can see two jobs failing:

@madrob
Copy link
Contributor Author

madrob commented Feb 18, 2026

Oh, strange. I see those in the failed checks now, but earlier GitHub was telling me only one job failed. Fixed those in 854f793

@madrob
Copy link
Contributor Author

madrob commented Feb 18, 2026

Everything is green!

@shahmishal
Copy link
Member

For the new action files, can you add read only permission?

permissions:
  contents: read

@madrob
Copy link
Contributor Author

madrob commented Feb 18, 2026

For the new action files, can you add read only permission?

Unlike .github/workflows, composite actions (files under .github/actions) cannot execute standalone and will always inherit the permissions from the calling workflow. There's no permission key to set on them.

see also: https://docs.github.com/en/actions/reference/workflows-and-actions/metadata-syntax

@shahmishal shahmishal merged commit c6fcbaf into swiftlang:main Feb 19, 2026
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using a versioned soundness.yml as an external workflow does not propagate tag to checkout jobs

3 participants

Comments